read/write syscalls: properly handle nbytes = 0

This commit is contained in:
Matheus
2024-07-30 20:30:55 -03:00
parent ed46c95d59
commit 4a7ccc208c
2 changed files with 10 additions and 8 deletions
+4 -2
View File
@@ -10,8 +10,9 @@ syscallret_t syscall_read(context_t *context, int fd, void *buffer, size_t size)
.ret = -1
};
void *kernelbuff = vmm_map(NULL, size, VMM_FLAGS_ALLOCATE, ARCH_MMU_FLAGS_READ | ARCH_MMU_FLAGS_WRITE | ARCH_MMU_FLAGS_NOEXEC, NULL);
void *kernelbuff = vmm_map(NULL, size == 0 ? 1 : size, VMM_FLAGS_ALLOCATE, ARCH_MMU_FLAGS_READ | ARCH_MMU_FLAGS_WRITE | ARCH_MMU_FLAGS_NOEXEC, NULL);
if (kernelbuff == NULL) {
printf("read enomem: %d %p %lu\n", fd, buffer, size);
ret.errno = ENOMEM;
return ret;
}
@@ -28,6 +29,7 @@ syscallret_t syscall_read(context_t *context, int fd, void *buffer, size_t size)
ret.errno = 0;
goto cleanup;
}
size_t bytesread;
uintmax_t offset = file->offset;
ret.errno = vfs_read(file->vnode, kernelbuff, size, file->offset, &bytesread, fileflagstovnodeflags(file->flags));
@@ -42,6 +44,6 @@ cleanup:
if (file)
fd_release(file);
vmm_unmap(kernelbuff, size, 0);
vmm_unmap(kernelbuff, size == 0 ? 1 : size, 0);
return ret;
}