mirrors/Astral
1
0
Fork 0
mirror of https://github.com/Mathewnd/Astral.git synced 2026-11-01 15:08:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

ext2: atomic symlink

Browse Source
This commit is contained in:
Matheus
2024-06-19 21:11:05 -03:00
parent a0ac16bec5
commit 984d74d327
1 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
kernel-src/fs/ext2.c
+14 -8
View File
@@ -1379,10 +1379,9 @@ static int ext2_link(vnode_t *vnode, vnode_t *dirvnode, char *name, cred_t *cred
return err; return err;
} }
static int ext2_create(vnode_t *parent, char *name, vattr_t *attr, int type, vnode_t **result, cred_t *cred) { static int internalcreate(vnode_t *parent, char *name, vattr_t *attr, int type, vnode_t **result, cred_t *cred) {
ext2node_t *node = (ext2node_t *)parent; ext2node_t *node = (ext2node_t *)parent;
ext2fs_t *fs = (ext2fs_t *)parent->vfs; ext2fs_t *fs = (ext2fs_t *)parent->vfs;
VOP_LOCK(parent);
ext2node_t *newnode = slab_allocate(nodecache); ext2node_t *newnode = slab_allocate(nodecache);
EXT2NODE_INIT(newnode, &vnops, 0, type, parent->vfs, 0); EXT2NODE_INIT(newnode, &vnops, 0, type, parent->vfs, 0);
@@ -1447,21 +1446,28 @@ static int ext2_create(vnode_t *parent, char *name, vattr_t *attr, int type, vno
if (err) if (err)
slab_free(nodecache, newnode); slab_free(nodecache, newnode);
return err;
}
static int ext2_create(vnode_t *parent, char *name, vattr_t *attr, int type, vnode_t **result, cred_t *cred) {
VOP_LOCK(parent);
int err = internalcreate(parent, name, attr, type, result, cred);
VOP_UNLOCK(parent); VOP_UNLOCK(parent);
return err; return err;
} }
// XXX this implementation isn't atomic in the create -> write target step
static int ext2_symlink(vnode_t *vnode, char *name, vattr_t *attr, char *path, cred_t *cred) { static int ext2_symlink(vnode_t *vnode, char *name, vattr_t *attr, char *path, cred_t *cred) {
ext2fs_t *fs = (ext2fs_t *)vnode->vfs; ext2fs_t *fs = (ext2fs_t *)vnode->vfs;
size_t linklen = strlen(path); size_t linklen = strlen(path);
vnode_t *newvnode;
int err = ext2_create(vnode, name, attr, V_TYPE_LINK, &newvnode, cred);
if (err)
return err;
VOP_LOCK(vnode); VOP_LOCK(vnode);
vnode_t *newvnode;
int err = internalcreate(vnode, name, attr, V_TYPE_LINK, &newvnode, cred);
if (err) {
VOP_UNLOCK(vnode);
return err;
}
VOP_LOCK(newvnode); VOP_LOCK(newvnode);
ext2node_t *newnode = (ext2node_t *)newvnode; ext2node_t *newnode = (ext2node_t *)newvnode;