mirrors/Astral
1
0
Fork 0
mirror of https://github.com/Mathewnd/Astral.git synced 2026-11-01 15:08:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

signal: fix lock ordering issue

Browse Source
This commit is contained in:
Matheus
2024-06-08 14:03:41 -03:00
parent 13b142a91e
commit f9c5a696c7
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
kernel-src/sys/signal.c
+8 -8
View File
@@ -217,6 +217,14 @@ void signal_signalproc(struct proc_t *proc, int signal) {
spinlock_release(&proc->threadlistlock); spinlock_release(&proc->threadlistlock);
// if its ignorable and there wasn't any thread with it unmasked, set it as pending for the whole process
// not ignorable signals will be sent to all threads individually
if (notignorable == false && (threadcontinued || shouldstop) == false) {
SIGNAL_SETON(&proc->signals.pending, signal);
}
PROCESS_LEAVE(proc);
// tell the parent that a child stopped // tell the parent that a child stopped
// TODO when stopping make sure that a thread was actually stopped // TODO when stopping make sure that a thread was actually stopped
// TODO protect parent with a spinlock // TODO protect parent with a spinlock
@@ -242,14 +250,6 @@ void signal_signalproc(struct proc_t *proc, int signal) {
semaphore_signal(&proc->parent->waitsem); semaphore_signal(&proc->parent->waitsem);
} }
// if its ignorable and there wasn't any thread with it unmasked, set it as pending for the whole process
// not ignorable signals will be sent to all threads individually
if (notignorable == false && (threadcontinued || shouldstop) == false) {
SIGNAL_SETON(&proc->signals.pending, signal);
}
PROCESS_LEAVE(proc);
} }
// returns true if should retry check // returns true if should retry check